lib: update encoding sets in WHATWG API
#49610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
encoding
pluris
changed the title
WHATWG APIWHATWG API
pluris
force-pushed
the
feat/add_encoding_whatwg
branch
from
8a63589 to
94fd779
Compare
daeyeon
reviewed
Sep 12, 2023
|
@daeyeon I guess I was looking at it wrong. I checked again and fixed it. Thank you for your good point. |
daeyeon
approved these changes
Sep 13, 2023
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
pluris
force-pushed
the
feat/add_encoding_whatwg
branch
from
28edd59 to
6a577bc
Compare
pluris
force-pushed
the
feat/add_encoding_whatwg
branch
from
5808a1f to
48a67a3
Compare
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
15 tasks
daeyeon
added
the
author ready
This was referenced Sep 15, 2023
JungMinu
approved these changes
Sep 22, 2023
daeyeon
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 55fde47 |
ruyadorno
pushed a commit
that referenced
this pull request
Sep 28, 2023
PR-URL: #49610 Refs: https://encoding.spec.whatwg.org/#names-and-labels Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Closed
Merged
alexfernandez
pushed a commit
to alexfernandez/node
that referenced
this pull request
Nov 1, 2023
PR-URL: nodejs#49610 Refs: https://encoding.spec.whatwg.org/#names-and-labels Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The encoding set has been updated according to the latest spec of
WHATWG.Refs: https://encoding.spec.whatwg.org/#names-and-labels